DBE Studio Query Formulator and Semantic Discovery Tool
The following document contains the results of FindBugs - http://findbugs.sourceforge.net/. This isn't formatted like a pretty CheckStyle / JDepend sheet as the FindBugs XML output is very terse and does not describe what each error type is. We have no desire to hardcode messages against FindBugs, so we'll wait until FindBugs XML output can be modified to produce easy to use messages.
H LI: Incorrect lazy initialization of static field org.dbe.studio.tools.discovery.QueryFormulatorUIPlugin.workingPath in org.dbe.studio.tools.discovery.QueryFormulatorUIPlugin.getWorkspacePath() At QueryFormulatorUIPlugin.java:[lines 230-241] H LI: Incorrect lazy initialization of static field org.dbe.studio.tools.discovery.QueryFormulatorUIPlugin.workingPath in org.dbe.studio.tools.discovery.QueryFormulatorUIPlugin.getWorkspacePathDepr() At QueryFormulatorUIPlugin.java:[lines 335-340] L NP: Possible null pointer dereference in org.dbe.studio.tools.discovery.QueryFormulatorUIPlugin.copyFile(java.io.File,String) on exception path At QueryFormulatorUIPlugin.java:[line 306] L NP: Possible null pointer dereference in org.dbe.studio.tools.discovery.QueryFormulatorUIPlugin.copyFile(java.io.File,String) on exception path At QueryFormulatorUIPlugin.java:[line 328] L OS: org.dbe.studio.tools.discovery.QueryFormulatorUIPlugin.copyFile(java.io.File,String) may fail to close stream on exception At QueryFormulatorUIPlugin.java:[line 300] L OS: org.dbe.studio.tools.discovery.QueryFormulatorUIPlugin.copyFile(java.io.File,String) may fail to close stream on exception At QueryFormulatorUIPlugin.java:[line 313] L LI: Incorrect lazy initialization of static field org.dbe.studio.tools.discovery.adapters.MofHelper.hash in org.dbe.studio.tools.discovery.adapters.MofHelper.retrieveHierarchy(String) At MofHelper.java:[lines 355-356] M RCN: Redundant comparison to null in org.dbe.studio.tools.discovery.dialogs.AddTemplateElementDialog.setProperty(org.dbe.studio.tools.discovery.treeNodes.AttributeNode,org.dbe.studio.tools.discovery.views.TemplateView) At AddTemplateElementDialog.java:[line 220] M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.BML_ID_PERSPECTIVE; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.ONTOLOGY_DESIGN_ID_PERSPECTIVE; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.PROPERTIES_ID_VIEW; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.QUICK_ID_VIEW; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.QYERY_WIZARD_ID; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.RESULT_ID_VIEW; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.SERV_COMP_ID_PERSPECTIVE; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.SERV_DEVELOP_ID_PERSPECTIVE; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.SERV_PUPLISH_ID_PERSPECTIVE; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.TEMPLATE_ID_VIEW; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.TEMPLATE_WIZARD_ID; should this field be static? M SS: Unread field: org.dbe.studio.tools.discovery.perspective.Perspective.TREE_ID_VIEW; should this field be static? M MS: org.dbe.studio.tools.discovery.providers.ModelContentProvider.EMPTY_ARRAY isn't final but should be L PZLA: Should org.dbe.studio.tools.discovery.providers.ModelContentProvider.getChildren(Object) return a zero length array rather than null? At ModelContentProvider.java:[line 31] M Dm: org.dbe.studio.tools.discovery.providers.ResultsItem.<clinit>() invokes dubious new String(String) constructor; just use the argument At ResultsItem.java:[line 55] M MS: org.dbe.studio.tools.discovery.providers.ResultsItem._BML_DATA_DESC isn't final but should be M MS: org.dbe.studio.tools.discovery.providers.ResultsItem._BML_DESC isn't final but should be M MS: org.dbe.studio.tools.discovery.providers.ResultsItem._SDL_DESC isn't final but should be M MS: org.dbe.studio.tools.discovery.providers.ResultsItem._SSL_DATA_DESC isn't final but should be M MS: org.dbe.studio.tools.discovery.providers.ResultsItem._SSL_DESC isn't final but should be L PZLA: Should org.dbe.studio.tools.discovery.providers.ResultsItem.getChildren() return a zero length array rather than null? At ResultsItem.java:[line 287] L DE: org.dbe.studio.tools.discovery.providers.Runner$MyMessageDialog.buttonPressed(int) might ignore java.lang.Exception At Runner.java:[line 90] M MS: org.dbe.studio.tools.discovery.si.DiscoveryServiceInvoker.si isn't final but should be M OS: org.dbe.studio.tools.discovery.tableItems.QbeTable.save(String) may fail to close stream At QbeTable.java:[line 120] M OS: org.dbe.studio.tools.discovery.tableItems.Template.save(String,boolean) may fail to close stream At Template.java:[line 166] M RCN: Redundant comparison to null in org.dbe.studio.tools.discovery.tableItems.Template.save(String,boolean) At Template.java:[line 173] M Dm: org.dbe.studio.tools.discovery.tableItems.TemplateElement.getContextToString() invokes dubious new String() constructor; just use "" At TemplateElement.java:[line 62] M EI: org.dbe.studio.tools.discovery.treeNodes.ContextRoot.getChildren() may expose internal representation by returning org.dbe.studio.tools.discovery.treeNodes.ContextRoot.children At ContextRoot.java:[line 186] M EI: org.dbe.studio.tools.discovery.treeNodes.ContextRoot.getObject() may expose internal representation by returning org.dbe.studio.tools.discovery.treeNodes.ContextRoot.context At ContextRoot.java:[line 177] M EI: org.dbe.studio.tools.discovery.treeNodes.NavigationNode.getChildren() may expose internal representation by returning org.dbe.studio.tools.discovery.treeNodes.NavigationNode.children At NavigationNode.java:[line 106] M EI: org.dbe.studio.tools.discovery.treeNodes.QueryNode.getChildren() may expose internal representation by returning org.dbe.studio.tools.discovery.treeNodes.QueryNode.children At QueryNode.java:[line 61] M UwF: Unwritten field: org.dbe.studio.tools.discovery.treeNodes.QueryNode.name M Dm: org.dbe.studio.tools.discovery.treeNodes.ValueNode.<init>(String,String,int,AbstractNode) invokes dubious new String() constructor; just use "" At ValueNode.java:[line 54] L PZLA: Should org.dbe.studio.tools.discovery.treeViewItems.TreeViewQbeTable.getChildren() return a zero length array rather than null? At TreeViewQbeTable.java:[line 35] L PZLA: Should org.dbe.studio.tools.discovery.treeViewItems.TreeViewTemplate.getChildren() return a zero length array rather than null? At TreeViewTemplate.java:[line 41] L OS: org.dbe.studio.tools.discovery.views.Results.save(String,String,String,String,org.dbe.studio.tools.discovery.tableItems.QbeTable) may fail to close stream on exception At Results.java:[line 452] L OS: org.dbe.studio.tools.discovery.views.Results.save(String,String,String,String,org.dbe.studio.tools.discovery.tableItems.QbeTable) may fail to close stream on exception At Results.java:[line 476] L NP: Possible null pointer dereference in org.dbe.studio.tools.discovery.views.TreeView.openTemplate(Object) on exception path At TreeView.java:[line 566] M UuF: Unused field: org.dbe.studio.tools.discovery.views.TreeView.propertiesView L SIC: Should org.dbe.studio.tools.discovery.views.TreeView$1 be a _static_ inner class? L PZLA: Should org.dbe.studio.tools.discovery.views.TreeView$TreeViewContentProvider.getChildren(Object) return a zero length array rather than null? At TreeView.java:[line 99] M SIC: Should org.dbe.studio.tools.discovery.views.TreeView$TreeViewLabelProvider be a _static_ inner class? M SIC: Should org.dbe.studio.tools.discovery.views.TreeView$TreeViewSorter be a _static_ inner class? L SIC: Should org.dbe.studio.tools.discovery.wizard.TemplateCreateWizardPage2$4 be a _static_ inner class?