Service Manifest Creator
The following document contains the results of FindBugs - http://findbugs.sourceforge.net/. This isn't formatted like a pretty CheckStyle / JDepend sheet as the FindBugs XML output is very terse and does not describe what each error type is. We have no desire to hardcode messages against FindBugs, so we'll wait until FindBugs XML output can be modified to produce easy to use messages.
L SIC: Should org.dbe.studio.tools.smcreator.common.ui.wizard.AbstractWizardPage$3 be a _static_ inner class? M SIC: Should org.dbe.studio.tools.smcreator.common.ui.wizard.AbstractWizardPage$BrowseSelectionAdapter be a _static_ inner class? M OS: org.dbe.studio.tools.smcreator.common.util.IOUtil.dumpFile(java.io.File) may fail to close stream At IOUtil.java:[line 52] L OS: org.dbe.studio.tools.smcreator.common.util.IOUtil.loadFile(java.io.File) may fail to close stream on exception At IOUtil.java:[line 17] L OS: org.dbe.studio.tools.smcreator.common.util.IOUtil.saveFile(java.io.File,String) may fail to close stream on exception At IOUtil.java:[line 45] H HE: org.dbe.studio.tools.smcreator.common.util.Uuid defines equals and uses Object.hashCode() M MS: org.dbe.studio.tools.smcreator.common.util.Uuid.csprngBuffer should be both final and package protected M MS: org.dbe.studio.tools.smcreator.common.util.Uuid.csprng isn't final but should be M UCF: Useless control flow in org.dbe.studio.tools.smcreator.common.util.Uuid.toString() At Uuid.java:[line 134] L Nm: Confusing to have methods org.dbe.studio.tools.smcreator.core.SMCreator.getSm() and org.dbe.studio.tools.smcreator.editor.SMEditor.getSM() M MS: org.dbe.studio.tools.smcreator.core.eb.SM.SM_TYPES is a mutable array M MS: org.dbe.studio.tools.smcreator.core.eb.SM.SM_TYPES_NAMES is a mutable array M UCF: Useless control flow in org.dbe.studio.tools.smcreator.editor.SMEditor.resourceChanged(org.eclipse.core.resources.IResourceChangeEvent) At SMEditor.java:[line 430] M UCF: Useless control flow in org.dbe.studio.tools.smcreator.editor.SMEditorContributor.setActivePage(org.eclipse.ui.IEditorPart) At SMEditorContributor.java:[line 49] M UrF: Unread field: org.dbe.studio.tools.smcreator.editor.SMEditorContributor.activeEditorPart L SIC: Should org.dbe.studio.tools.smcreator.editor.SMEditorContributor$1 be a _static_ inner class? M ES: Comparison of String objects using == or != in org.dbe.studio.tools.smcreator.editor.SMEditorPage$SelectIfServiceAdapter.widgetSelected(org.eclipse.swt.events.SelectionEvent) At SMEditorPage.java:[line 333] M SIC: Should org.dbe.studio.tools.smcreator.editor.SMEditorPage$SelectIfServiceAdapter be a _static_ inner class? M MS: org.dbe.studio.tools.smcreator.ifrm.core.IfMgr.if_service_header_xmljmap should be package protected M MS: org.dbe.studio.tools.smcreator.ifrm.core.IfMgr.if_service_xmljmap should be package protected M MS: org.dbe.studio.tools.smcreator.ifrm.core.eb.BasicContact.basic_provider_info_xmljmap should be package protected M UwF: Unwritten field: org.dbe.studio.tools.smcreator.ifrm.core.eb.BasicItemInfo.itemInfos M MS: org.dbe.studio.tools.smcreator.ifrm.core.eb.BasicPayment.basic_payment_xmljmap should be package protected M MS: org.dbe.studio.tools.smcreator.ifrm.core.eb.BasicProviderInfo.basic_provider_info_xmljmap is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.core.eb.IfConst.CONTACT_TYPE_DESCR is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.core.eb.IfConst.CONTACT_TYPE_NAME is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.core.eb.IfConst.PAYMENT_TYPE_DESCR is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.core.eb.IfConst.PAYMENT_TYPE_NAME is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.selling.ItemData.XMLT_ITEM_DATA isn't final but should be M MS: org.dbe.studio.tools.smcreator.ifrm.selling.ItemInfo.XMLT_ITEM_INFO isn't final but should be L PZLA: Should org.dbe.studio.tools.smcreator.ifrm.selling.ItemInfo.toStringArrayValues() return a zero length array rather than null? At ItemInfo.java:[line 45] M MS: org.dbe.studio.tools.smcreator.ifrm.selling.SellConst.SELL_BOOK_ITEM_DATA_DESCR is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.selling.SellConst.SELL_BOOK_ITEM_DATA_NAME is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.selling.SellConst.SELL_CAR_ITEM_DATA_DESCR is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.selling.SellConst.SELL_CAR_ITEM_DATA_NAME is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.selling.SellConst.SELL_ITEM_DESCR is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.selling.SellConst.SELL_ITEM_NAME is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.selling.SellConst.SELL_PROVIDER_DATA_DESCR is a mutable array M MS: org.dbe.studio.tools.smcreator.ifrm.selling.SellConst.SELL_PROVIDER_DATA_NAME is a mutable array M Dm: org.dbe.studio.tools.smcreator.ifrm.selling.ui.BookDataPage.<init>(org.eclipse.jface.wizard.Wizard) invokes dubious new String(String) constructor; just use the argument At BookDataPage.java:[line 38] M Dm: org.dbe.studio.tools.smcreator.ifrm.selling.ui.CarDataPage.<init>(org.eclipse.jface.wizard.Wizard) invokes dubious new String(String) constructor; just use the argument At CarDataPage.java:[line 38] M EI: org.dbe.studio.tools.smcreator.ifrm.selling.ui.DataEntryDialog.getLabels() may expose internal representation by returning org.dbe.studio.tools.smcreator.ifrm.selling.ui.DataEntryDialog.labels At DataEntryDialog.java:[line 115] M EI: org.dbe.studio.tools.smcreator.ifrm.selling.ui.DataEntryDialog.getTextWidgets() may expose internal representation by returning org.dbe.studio.tools.smcreator.ifrm.selling.ui.DataEntryDialog.txt At DataEntryDialog.java:[line 185] M EI: org.dbe.studio.tools.smcreator.ifrm.selling.ui.DataEntryDialog.getValues() may expose internal representation by returning org.dbe.studio.tools.smcreator.ifrm.selling.ui.DataEntryDialog.values At DataEntryDialog.java:[line 129] M UrF: Unread field: org.dbe.studio.tools.smcreator.ifrm.selling.ui.RequestInfoPage.requestInfo M SIC: Should org.dbe.studio.tools.smcreator.modellist.ModelTableViewer$ViewContentProvider be a _static_ inner class? M SIC: Should org.dbe.studio.tools.smcreator.modellist.ModelTableViewer$ViewLabelProvider be a _static_ inner class? M MS: org.dbe.studio.tools.smcreator.plugin.SMCreatorMsg.MOD_VIEW_COLS is a mutable array L DE: org.dbe.studio.tools.smcreator.wizard.ui.NewSMWizard$1.run() might ignore org.eclipse.ui.PartInitException At NewSMWizard.java:[line 178] L SIC: Should org.dbe.studio.tools.smcreator.wizard.ui.NewSMWizard$1 be a _static_ inner class?