DBE Studio BML Editor
The following document contains the results of FindBugs - http://findbugs.sourceforge.net/. This isn't formatted like a pretty CheckStyle / JDepend sheet as the FindBugs XML output is very terse and does not describe what each error type is. We have no desire to hardcode messages against FindBugs, so we'll wait until FindBugs XML output can be modified to produce easy to use messages.
L DE: org.dbe.studio.editors.bml.BMLEditorMain.saveSSLinMDR(org.dbe.studio.editors.bml.metamodels.ssl.ModelDiagram,boolean) might ignore javax.jmi.reflect.CompositionViolationException At BMLEditorMain.java:[line 1849] M MS: org.dbe.studio.editors.bml.BMLEditorMain.fadaNodeAddress isn't final and can't be M MS: org.dbe.studio.editors.bml.BMLEditorMain.modelElementCounter isn't final and can't be M MS: org.dbe.studio.editors.bml.BMLEditorMain.theBMLtool isn't final and can't be M MS: org.dbe.studio.editors.bml.BMLEditorMain.theKBIservice isn't final and can't be M MS: org.dbe.studio.editors.bml.BMLEditorMain.theSSLtool isn't final and can't be M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.BMLEditorMain.doSaveAs() At BMLEditorMain.java:[line 799] M ES: Comparison of String objects using == or != in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 99] M NP: Possible null pointer dereference in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 457] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 90] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 126] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 137] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 147] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 157] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 168] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 179] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 190] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 204] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 220] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 230] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 240] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 250] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 260] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 270] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 280] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 291] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 301] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 311] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 321] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 331] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 341] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 351] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 361] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 371] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 383] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 394] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 404] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 415] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 425] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 435] M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.GraphicalEditPartFactory.createEditPart(org.eclipse.gef.EditPart,Object) At GraphicalEditPartFactory.java:[line 445] M UrF: Unread field: org.dbe.studio.editors.bml.actions.DeleteModelAction.viewer M RCN: Redundant comparison to null in org.dbe.studio.editors.bml.actions.ExportBMLModelAction.run() At ExportBMLModelAction.java:[line 90] M ES: Comparison of String objects using == or != in org.dbe.studio.editors.bml.commands.CreateBasicNodeElementCmd.execute() At CreateBasicNodeElementCmd.java:[line 64] M UCF: Useless control flow in org.dbe.studio.editors.bml.commands.DirectEditAttributeCmd.undo() At DirectEditAttributeCmd.java:[line 220] M UrF: Unread field: org.dbe.studio.editors.bml.commands.DirectEditAttributeCmd.oldRole M ES: Comparison of String objects using == or != in org.dbe.studio.editors.bml.commands.SetConstraintModelDiagramCmd.redo() At SetConstraintModelDiagramCmd.java:[line 155] M ES: Comparison of String objects using == or != in org.dbe.studio.editors.bml.commands.SetConstraintModelDiagramCmd.undo() At SetConstraintModelDiagramCmd.java:[line 103] M UrF: Unread field: org.dbe.studio.editors.bml.editParts.BmlTransactionSenderReceiverEditPart.theSite M UuF: Unused field: org.dbe.studio.editors.bml.editPolicies.BasicNodeGraphicalNodeEditPolicy.sourcemodel M UuF: Unused field: org.dbe.studio.editors.bml.editPolicies.BasicNodeGraphicalNodeEditPolicy.targetmodel M SIC: Should org.dbe.studio.editors.bml.figures.CompartmentFigure$CompartmentFigureBorder be a _static_ inner class? M MS: org.dbe.studio.editors.bml.figures.NoteBorderFigure.DEFAULT_CORNER_SIZE isn't final but should be M ES: Comparison of String objects using == or != in org.dbe.studio.editors.bml.metamodels.basic.BasicGroupElement.toString() At BasicGroupElement.java:[line 142] M MS: org.dbe.studio.editors.bml.metamodels.basic.BasicModelElement.id isn't final and can't be M ES: Comparison of String objects using == or != in org.dbe.studio.editors.bml.metamodels.basic.BasicMultiplicity.getMultiplicity() At BasicMultiplicity.java:[line 88] M ES: Comparison of String objects using == or != in org.dbe.studio.editors.bml.metamodels.basic.BasicMultiplicity.setMultiplicity(String) At BasicMultiplicity.java:[line 76] M Se: Class org.dbe.studio.editors.bml.metamodels.basic.TypeElement defines non-transient non-serializable instance field org.dbe.studio.editors.bml.metamodels.ssl.BMLOntologyClass.complexType At unknown source line M MS: org.dbe.studio.editors.bml.metamodels.ssl.Identifier.ID should be package protected M UR: Uninitialized read of org.dbe.studio.editors.bml.metamodels.ssl.SMEInformations.listeners in org.dbe.studio.editors.bml.metamodels.ssl.SMEInformations.<init>() At SMEInformations.java:[line 32] M Se: Class org.dbe.studio.editors.bml.metamodels.ssl.ServiceAttribute defines non-transient non-serializable instance field org.dbe.studio.editors.bml.metamodels.ssl.BMLOntologyClass.complexAttributeType At unknown source line M Se: Class org.dbe.studio.editors.bml.metamodels.ssl.ServiceInput defines non-transient non-serializable instance field org.dbe.studio.editors.bml.metamodels.ssl.BMLOntologyClass.complexServiceInputType At unknown source line M Se: Class org.dbe.studio.editors.bml.metamodels.ssl.ServiceOutput defines non-transient non-serializable instance field org.dbe.studio.editors.bml.metamodels.ssl.BMLOntologyClass.complexServiceOutputType At unknown source line M EI: org.dbe.studio.editors.bml.models.ModelNavigatorTreeContentProvider.getChildren(Object) may expose internal representation by returning org.dbe.studio.editors.bml.models.ModelNavigatorTreeContentProvider.EMPTY_ARRAY At ModelNavigatorTreeContentProvider.java:[line 40] M EI: org.dbe.studio.editors.bml.models.ModelNavigatorTreeContentProvider.getChildren(Object) may expose internal representation by returning org.dbe.studio.editors.bml.models.ModelNavigatorTreeContentProvider.EMPTY_ARRAY At ModelNavigatorTreeContentProvider.java:[line 48] M EI: org.dbe.studio.editors.bml.models.ModelNavigatorTreeContentProvider.getChildren(Object) may expose internal representation by returning org.dbe.studio.editors.bml.models.ModelNavigatorTreeContentProvider.EMPTY_ARRAY At ModelNavigatorTreeContentProvider.java:[line 52] M EI: org.dbe.studio.editors.bml.models.ModelNavigatorTreeContentProvider.getElements(Object) may expose internal representation by returning org.dbe.studio.editors.bml.models.ModelNavigatorTreeContentProvider.EMPTY_ARRAY At ModelNavigatorTreeContentProvider.java:[line 100] M UR: Uninitialized read of org.dbe.studio.editors.bml.models.SMEInformation.listeners in org.dbe.studio.editors.bml.models.SMEInformation.<init>() At SMEInformation.java:[line 32] L DE: org.dbe.studio.editors.bml.utils.Base64.decode(String) might ignore java.lang.Exception At Base64.java:[line 676] L DE: org.dbe.studio.editors.bml.utils.Base64.encodeBytes(byte[],int,int,int) might ignore java.lang.Exception At Base64.java:[line 428] L DE: org.dbe.studio.editors.bml.utils.Base64.encodeObject(java.io.Serializable,int) might ignore java.lang.Exception At Base64.java:[line 307] H NP: Null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.decodeFromFile(String) At Base64.java:[line 837] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.decode(String) on exception path At Base64.java:[line 675] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.decode(String) on exception path At Base64.java:[line 678] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.decode(String) on exception path At Base64.java:[line 681] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.decodeFromFile(String) on exception path At Base64.java:[line 837] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.decodeToFile(String,String) on exception path At Base64.java:[line 783] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.decodeToObject(String) on exception path At Base64.java:[line 721] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.decodeToObject(String) on exception path At Base64.java:[line 724] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeBytes(byte[],int,int,int) on exception path At Base64.java:[line 427] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeBytes(byte[],int,int,int) on exception path At Base64.java:[line 430] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeBytes(byte[],int,int,int) on exception path At Base64.java:[line 433] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeFromFile(String) on exception path At Base64.java:[line 882] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeObject(java.io.Serializable,int) on exception path At Base64.java:[line 306] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeObject(java.io.Serializable,int) on exception path At Base64.java:[line 309] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeObject(java.io.Serializable,int) on exception path At Base64.java:[line 312] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeObject(java.io.Serializable,int) on exception path At Base64.java:[line 315] L NP: Possible null pointer dereference in org.dbe.studio.editors.bml.utils.Base64.encodeToFile(byte[],String) on exception path At Base64.java:[line 754] L PZLA: Should org.dbe.studio.editors.bml.utils.Base64.decode(byte[],int,int) return a zero length array rather than null? At Base64.java:[line 617] M MS: org.dbe.studio.editors.bml.utils.ChangeModelNamePage.IS_FIRST_TIME isn't final but should be M MS: org.dbe.studio.editors.bml.utils.ComboBoxDirectEditManager.PRIMITIVE_TYPES is a mutable array M MS: org.dbe.studio.editors.bml.utils.Constants.BIZPROCESS_BIZPROCESS_ASSOC is a mutable array M MS: org.dbe.studio.editors.bml.utils.Constants.B_PROCESS_B_ACTIVITY_ASSOC is a mutable array M MS: org.dbe.studio.editors.bml.utils.Constants.COLLABORATION_ACTIV_TRANS_ASSOC is a mutable array M MS: org.dbe.studio.editors.bml.utils.Constants.CONSTRAINT_BEHAVIOUR_ASSOC is a mutable array M MS: org.dbe.studio.editors.bml.utils.Constants.EVENT_BEHAVIOUR_ASSOC is a mutable array M MS: org.dbe.studio.editors.bml.utils.Constants.RESOURCE_BEHAVIOUR_ASSOC is a mutable array M EI: org.dbe.studio.editors.bml.utils.DomainContentProvider.getChildren(Object) may expose internal representation by returning org.dbe.studio.editors.bml.utils.DomainContentProvider.EMPTY_ARRAY At DomainContentProvider.java:[line 36] M EI: org.dbe.studio.editors.bml.utils.DomainContentProvider.getElements(Object) may expose internal representation by returning org.dbe.studio.editors.bml.utils.DomainContentProvider.EMPTY_ARRAY At DomainContentProvider.java:[line 64] M EI: org.dbe.studio.editors.bml.utils.DomainContentProvider.getParent(Object) may expose internal representation by returning org.dbe.studio.editors.bml.utils.DomainContentProvider.EMPTY_ARRAY At DomainContentProvider.java:[line 46] M EI: org.dbe.studio.editors.bml.utils.NavigatorContentProvider.getChildren(Object) may expose internal representation by returning org.dbe.studio.editors.bml.utils.NavigatorContentProvider.EMPTY_ARRAY At NavigatorContentProvider.java:[line 49] M EI: org.dbe.studio.editors.bml.utils.NavigatorContentProvider.getElements(Object) may expose internal representation by returning org.dbe.studio.editors.bml.utils.NavigatorContentProvider.EMPTY_ARRAY At NavigatorContentProvider.java:[line 75] M EI: org.dbe.studio.editors.bml.utils.OutlineContentProvider.getChildren(Object) may expose internal representation by returning org.dbe.studio.editors.bml.utils.OutlineContentProvider.EMPTY_ARRAY At OutlineContentProvider.java:[line 105] M EI: org.dbe.studio.editors.bml.utils.OutlineContentProvider.getElements(Object) may expose internal representation by returning org.dbe.studio.editors.bml.utils.OutlineContentProvider.EMPTY_ARRAY At OutlineContentProvider.java:[line 153] L DE: org.dbe.studio.editors.bml.utils.Runner$MyMessageDialog.buttonPressed(int) might ignore java.lang.Exception At Runner.java:[line 77] M UCF: Useless control flow in org.dbe.studio.editors.bml.utils.SMEWizard.init(org.eclipse.ui.IWorkbench,org.eclipse.jface.viewers.IStructuredSelection) At SMEWizard.java:[line 68] M UrF: Unread field: org.dbe.studio.editors.bml.utils.listeners.MenuBarListener.editorPart M UwF: Unwritten field: org.dbe.studio.editors.bml.utils.listeners.MenuBarListener.listener M MS: org.dbe.studio.editors.bml.views.ModelNavigatorView.theKBIservice isn't final and can't be M MS: org.dbe.studio.editors.bml.views.ModelNavigatorView.theSME isn't final and can't be M UwF: Unwritten field: org.dbe.studio.editors.bml.views.ModelNavigatorView.linkTargetPath L SIC: Should org.dbe.studio.editors.bml.views.ModelNavigatorView$1 be a _static_ inner class?